fix(header): improve navbar scroll behavior with banner support#1669
Conversation
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
|
Thanks for the review and merge! |
Description
The navbar should remain visible while the user is inside the hero section.
After crossing the hero section, the navbar visibility should depend on scroll direction:
Scroll DOWN → hide navbar
Scroll UP → show navbar
This improves user experience and prevents sudden header disappearance at the top of the page.
Additionally, when the activity banner is enabled, the navbar and banner now behave as a single unit.
They hide and show together based on the same scroll logic, preventing:
If the banner is disabled, the navbar continues to work exactly as before.
Without activity banner
With activity banner enabled
Fixes #1665
Type of change
How Has This Been Tested?
Tested locally in the browser.
Checklist:
Screenshots or example output